feat: Build docker image with both amd64 and arm64 support #10882
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #10882 +/- ##
=========================================
Coverage 57.51% 57.51%
Complexity 1707 1707
=========================================
Files 346 346
Lines 12855 12855
Branches 1215 1215
=========================================
Hits 7394 7394
Misses 4996 4996
Partials 465 465
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
What is the current state on this? I Just stumbled across this PR when trying to get the Dockerimage to run on my Mac and this PR also fixes all previous build issues I had :) |
See the "This branch has conflicts that must be resolved" hint below. We agreed in one of the recent community meetings (Which you're very welcome to join!) to pause this until #10964 is merged as we knew it to conflict. But since that has happened now, I guess @heliocastro just needs to find the time to rebase & resolve the conflicts. |
Signed-off-by: Helio Chissini de Castro <[email protected]>
Signed-off-by: Helio Chissini de Castro <[email protected]>
Scancode utility scancode-license-data has a flaw that inside some environments ignores the path flag. The dependency on distutils, deprecated since Python 3.12+ force install of setuptools to match requirements, but not properly a substitute for distutils. Signed-off-by: Helio Chissini de Castro <[email protected]>
heliocastro
force-pushed
the
feat/docker_multiarch
branch
from
30288b1 to
2bfb7ce
Compare
|
@janniclas @sselbach Just rebased, but remember that i paused in favor of the new solution proposed by @sschuberth . |
|
I'm happy to help out if you can point me to the new solution proposed by Sebastian, so I've a starting point. |
| && wget https://github.com/conan-io/conan/releases/download/$CONAN2_VERSION/conan-$CONAN2_VERSION-linux-x86_64.tgz \ | ||
| && tar -xvf conan-$CONAN2_VERSION-linux-x86_64.tgz\ | ||
| setuptools=="$PYTHON_SETUPTOOLS_VERSION" \ | ||
| uv="$UV_VERSION" |
There was a problem hiding this comment.
uv=="$UV_VERSION" there is a = missing
| && pyenv install -v $PYTHON_VERSION \ | ||
| && pyenv global $PYTHON_VERSION | ||
|
|
||
| RUN ARCH=$(arch | sed s/aarch64/arm64/) \ |
There was a problem hiding this comment.
To work on Mac you also need to manually install click in version 8.2.1
&& if [ "$ARCH" == "arm64" ]; then \
pip install -U \
click==$PYTHON_CLICK_VERSION \
scancode-toolkit-mini==$SCANCODE_VERSION; \
else \
pip install -U scancode-toolkit==$SCANCODE_VERSION; \
fi```
Use docker own emulation action to build multiarch image.